-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmenzel
reviewed
Jun 4, 2018
@@ -36,7 +36,7 @@ mee_build() { | |||
} | |||
|
|||
mee_install() { | |||
bee_install | |||
make install prefix=${D}/${PREFIX} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the rational to the commit message. Why does bee_install
fail?
Why does bee_install fail? |
Am 04.06.2018 um 13:19 schrieb Thomas Kreitler:
Why does bee_install fail?
`[BEE] action 'bee_install' is not defined: skipping..` looks like a failure, or ?
Yes, but why does that happen? Looking at the bee file there is:
BEE_CONFIGURE=none
So how did that bee file ever work?
|
|
Looks like you are itching to complete the task, go ahead :) |
Am 04.06.2018 um 14:46 schrieb Thomas Kreitler:
Looks like you are itching to complete the task, go ahead :)
Thank you for the offer, but I do not itch for it. Review is enough.
|
Well, I appreciate your comments as proposals. But actually I can live with GTK2 and the bee file in its current state. |
Remove unused PGRP, and use 'build_in_sourcedir' makro.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale: