Skip to content

Update scite from 2.23 to 4.0.5 #802

Merged
merged 4 commits into from
Jun 11, 2018
Merged

Conversation

thomas
Copy link
Collaborator

@thomas thomas commented Jun 4, 2018

Rationale:

  • The former version is over 7 years old
  • Highlights from the change-log include background saving, really large files...

@@ -36,7 +36,7 @@ mee_build() {
}

mee_install() {
bee_install
make install prefix=${D}/${PREFIX}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the rational to the commit message. Why does bee_install fail?

@thomas
Copy link
Collaborator Author

thomas commented Jun 4, 2018

Why does bee_install fail?
[BEE] action 'bee_install' is not defined: skipping.. looks like a failure, or ?

@pmenzel
Copy link
Collaborator

pmenzel commented Jun 4, 2018 via email

@pmenzel
Copy link
Collaborator

pmenzel commented Jun 4, 2018

  1. While you at it, it’d be great if you updated the bee file too, that means remove outdated commands/meta data (build_in_sourcedir, …).

  2. Also, make -C ${S}/scintilla/gtk is shorter in my opinion.

  3. If you could it build it with GTK+ 3, that’d be great.

mee_build() {
    make -C ${S}/scintilla/gtk GTK3=1
    make -C ${S}/scite/gtk GTK3=1
}

mee_install() {
    make install -C ${S}/scite/gtk prefix=${D}/${PREFIX}
    ln -s SciTE ${D}${BINDIR}/scite
}

@thomas
Copy link
Collaborator Author

thomas commented Jun 4, 2018

Looks like you are itching to complete the task, go ahead :)

@pmenzel
Copy link
Collaborator

pmenzel commented Jun 4, 2018 via email

@thomas
Copy link
Collaborator Author

thomas commented Jun 4, 2018

Well, I appreciate your comments as proposals. But actually I can live with GTK2 and the bee file in its current state.

Remove unused PGRP, and use 'build_in_sourcedir' makro.
@donald donald merged commit 2540450 into master Jun 11, 2018
@donald donald deleted the update-scite-from-2.23-to-4.0.5 branch September 14, 2018 08:45
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants